Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure eslint plugins dont conflict #35667

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 28, 2022

This fixes when a user manually installs an eslint-plugin that we also use in eslint-config-next and the dependency isn't de-duped due to differing versions being installed. Since eslint errors for duplicate versions being installed when loading the config this works around this by modifying how we resolve these plugins and favoring the manually installed version falling back to our version.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #35606

@ijjk
Copy link
Member Author

ijjk commented Mar 28, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
buildDuration 15.6s 15.7s ⚠️ +86ms
buildDurationCached 6.1s 6.1s -54ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
/ failed reqs 0 0
/ total time (seconds) 3.133 3.14 ⚠️ +0.01
/ avg req/sec 797.89 796.19 ⚠️ -1.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.354 1.358 0
/error-in-render avg req/sec 1846.76 1840.82 ⚠️ -5.94
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.48 kB 5.48 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.2 kB 15.2 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
buildDuration 18.9s 18.9s ⚠️ +26ms
buildDurationCached 6.1s 6.1s -20ms
nodeModulesSize 467 MB 467 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
/ failed reqs 0 0
/ total time (seconds) 3.126 3.13 0
/ avg req/sec 799.67 798.61 ⚠️ -1.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.362 1.357 -0.01
/error-in-render avg req/sec 1835.01 1842.12 +7.11
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.59 kB 5.59 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.33 kB 2.33 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 388 B 388 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.3 kB 15.3 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/eslint-plugin-conflict Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 6607b69

@charkour
Copy link
Contributor

charkour commented Apr 6, 2022

This makes running next lint significantly slower than before. This is a pain point when we run next lint as a pre-commit hook. Any suggestions on how to resolve this? Perhaps we should update our pre-commit hook to only lint files that are changed. Running next lint seems to lint the entire project.

Thanks for the great work and all your contributions!

@ijjk ijjk deleted the fix/eslint-plugin-conflict branch April 28, 2022 18:00
@ijjk
Copy link
Member Author

ijjk commented Apr 28, 2022

@charkour this sounds unlikely to be related to this change as a map lookup is used which is the same as the existing require hook present in Next.js

@charkour
Copy link
Contributor

Thanks for the response! I'll keep investigating. Through testing, it appeared the slowdown happened when upgrading to this nextjs verison.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint not working after updating eslint-config-next to v12.1.1
3 participants